This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added json serialization of timestamp/date32/date64 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #814 +/- ##
==========================================
+ Coverage 71.27% 71.28% +0.01%
==========================================
Files 327 327
Lines 17543 17571 +28
==========================================
+ Hits 12503 12525 +22
- Misses 5040 5046 +6
Continue to review full report at Codecov.
|
|
small conflict |
|
Thanks, @ritchie46 ! |
jorgecarleitao
changed the title
jorgecarleitao
added
feature
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Feb 6, 2022
jorgecarleitao
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds serialization of dates and timestamp. I started with the default
Displayimplementation from chrono. We could add formatter later if that's required.